[MPlayer-dev-eng] [PATCH] mmap support for OS/2

[Dave Yeo]

On 02/26/08 02:41 pm, Diego Biurrun wrote:
> On Mon, Feb 25, 2008 at 07:51:44PM +0900, KO Myung-Hun wrote:
>>
>> --- osdep/mmap.h	(revision 0)
>> +++ osdep/mmap.h	(revision 0)
>> @@ -0,0 +1,56 @@
>> +/*
>> + * mmap.h : mmap declaration header for sys/mman.h missing system
>
> mmap declaration header for systems missing sys/mman.h

As we do have (nonfunctional) sys/mman.h 
(http://svn.netlabs.org/libc/browser/branches/libc-0.6/src/emx/include/sys/mman.h) 
perhaps better comment would be
mmap declaration  header for systems nonfunctional sys/mman.h

...
>
> Does anybody else have comments about this patch?
>

As a simple mmap implementation it looks fine here.
There does need to be another patch to make this useful IMO though.

> Diego

Dave