[MPlayer-dev-eng] [PATCH] mmap support for OS/2

[Diego Biurrun]

On Mon, Feb 25, 2008 at 07:51:44PM +0900, KO Myung-Hun wrote:
>
>
> --- osdep/mmap.h	(revision 0)
> +++ osdep/mmap.h	(revision 0)
> @@ -0,0 +1,56 @@
> +/*
> + * mmap.h : mmap declaration header for sys/mman.h missing system

mmap declaration header for systems missing sys/mman.h

> --- osdep/mmap-os2.c	(revision 0)
> +++ osdep/mmap-os2.c	(revision 0)
> @@ -0,0 +1,212 @@
> +/*
> + * mmap-os2.c : Very simple implementation of mmap function for OS/2

very simple implementation of mmap() for OS/2

> +struct os2_mmap_s;
> +typedef struct os2_mmap_s
> +{
> +    void    *addr;
> +    size_t  len;
> +    int     flags;
> +    struct os2_mmap_s *prev;
> +    struct os2_mmap_s *next;
> +} os2_mmap;

> +static os2_mmap *_mmap = NULL;

Identifiers starting with _ and lowercase are reserved at the file
level.  You are not using it outside this file, but it's still ugly.

> +        // Allocate tiled memory compatible with 16-bit selectors
> +        // 'fs_seg' in 'ldt_keeper.c' need this attr

attribute

Does anybody else have comments about this patch?

Diego