[MPlayer-dev-eng] [PATCH] demuxer-independent sub and audio track selection

Uoti Urpala uoti.urpala at pp1.inet.fi
Mon Feb 25 18:44:32 CET 2008


On Sun, 2008-02-24 at 16:31 +0100, Reimar Döffinger wrote:
> > +                strncpy(lang, sh->lang, 39);
> > +                lang[39] = 0;

> strncpy should be considered forbidden for new code, use av_strlcpy.

I think "forbidden" is too strong when it's two lines of standard code
vs a nonstandard function. Not that I really oppose use of av_strlcpy
either, but if you want to use it at least fix it to do what the
documentation says...




More information about the MPlayer-dev-eng mailing list