[MPlayer-dev-eng] squelch some warnings (patches incl.)

Michael Niedermayer michaelni at gmx.at
Sat Feb 23 21:53:55 CET 2008


On Sat, Feb 23, 2008 at 07:19:33PM +0100, Elias Pipping wrote:
> On Sat, Feb 23, 2008 at 06:29:11PM +0100, Diego Biurrun wrote:
> > On Fri, Feb 22, 2008 at 02:56:46PM +0100, Elias Pipping wrote:
> > > 
> > > I've attached a couple of patches to squelch some warnings, mostly on
> > > Mac OS X (tested with 10.5.2 on an Intel Mac).
> > 
> > What warnings is this supposed to fix?
[...]
>     15  snow.c:4404: warning: implicit declaration of function ‘dwt_quantize’
>   %
> 
> The last line is being taken care of by this[1] patch (attached, too).
> 
> 
> -- Elias
> 
> [1] http://overlays.gentoo.org/proj/alt/browser/trunk/prefix-overlay/media-video/mplayer/files/mplayer-1.0-quantize2.patch?rev=17019

> --- libavcodec/snow.c
> +++ libavcodec/snow.c
> @@ -4390,10 +4390,11 @@
>              }
>          }
>  
> -        if(QUANTIZE2)
> +#if QUANTIZE2 == 1
>              dwt_quantize(s, p, s->spatial_dwt_buffer, w, h, w, s->spatial_decomposition_type);
> -        else
> +#else
>              ff_spatial_dwt(s->spatial_dwt_buffer, w, h, w, s->spatial_decomposition_type, s->spatial_decomposition_count);
> +#endif

rejected, this is not a proper fix for a missing declaration

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080223/3b0a13d3/attachment.pgp>


More information about the MPlayer-dev-eng mailing list