[MPlayer-dev-eng] [PATCH] clarify useless //input regs comment in vf_fspp.c
Reimar Döffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Feb 23 21:47:22 CET 2008
Hello,
does attached patch look okay to you?
Greetings,
Reimar Döffinger
-------------- next part --------------
diff --git a/libmpcodecs/vf_fspp.c b/libmpcodecs/vf_fspp.c
index 419817d..83d9e62 100644
--- a/libmpcodecs/vf_fspp.c
+++ b/libmpcodecs/vf_fspp.c
@@ -1589,7 +1589,8 @@ static void column_fidct_mmx(int16_t* thr_adr, DCTELEM *data, DCTELEM *output,
"jnz 1b \n\t"
"5: \n\t"
- : "+S"(data), "+D"(output), "+c"(cnt)// input regs
+// + constraints are inputs that are modified and thus cannot be in the input section
+ : "+S"(data), "+D"(output), "+c"(cnt)
: "d"(thr_adr)
: "%"REG_a
);
@@ -1857,7 +1858,8 @@ static void row_idct_mmx (DCTELEM* workspace,
"dec %%"REG_c" \n\t"
"jnz 1b \n\t"
- : "+S"(workspace), "+D"(output_adr), "+c"(cnt) //input regs
+// + constraints are inputs that are modified and thus cannot be in the input section
+ : "+S"(workspace), "+D"(output_adr), "+c"(cnt)
: "a"(output_stride*sizeof(short))
: "%"REG_d
);
@@ -2100,8 +2102,9 @@ static void row_fdct_mmx(DCTELEM *data, const uint8_t *pixels, int line_size,
"add $"DCTSIZE_S"*2*4, %%"REG_D" \n\t" //4 rows
"dec %%"REG_c" \n\t"
"jnz 6b \n\t"
-
- : "+S"(pixels), "+D"(data), "+c"(cnt) //input regs
+
+// + constraints are inputs that are modified and thus cannot be in the input section
+ : "+S"(pixels), "+D"(data), "+c"(cnt)
: "a"(line_size)
: "%"REG_d);
}
More information about the MPlayer-dev-eng
mailing list