[MPlayer-dev-eng] [PATCH] compile codec-cfg with -O

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Feb 23 21:32:13 CET 2008


Hello,
currently codec-cfg (the host-native one that creates the codecs.conf.h)
is compiled without any options.
Compilers seem to be very, very badly tested for this though, and in the
past I have seen problems with gcc, though they were gone very fast.
Today I got the following with Sun's compiler, it did emit this:
"rorw $8, %st(7)"
and of course could not compile.
Adding -O fixed it.
So to avoid this nuisance (even though these are obviously compiler
bugs) I suggest this change, ok to apply?

Index: Makefile
===================================================================
--- Makefile    (revision 26061)
+++ Makefile    (working copy)
@@ -230,7 +230,7 @@
        $(CC) -o $@ $^ $(LDFLAGS_MENCODER)
 
 codec-cfg$(EXESUF): codec-cfg.c codec-cfg.h help_mp.h
-       $(HOST_CC) -I. -DCODECS2HTML $< -o $@
+       $(HOST_CC) -O -I. -DCODECS2HTML $< -o $@
 
 codecs.conf.h: codec-cfg$(EXESUF) etc/codecs.conf
        ./codec-cfg$(EXESUF) ./etc/codecs.conf > $@




More information about the MPlayer-dev-eng mailing list