[MPlayer-dev-eng] [PATCH] Get rid of non const static variable temps in vf_fspp.c

Uoti Urpala uoti.urpala at pp1.inet.fi
Sat Feb 23 20:37:10 CET 2008


On Sat, 2008-02-23 at 14:45 +0100, Carl Eugen Hoyos wrote:
> Attached patch tries to discard the non const static variable temps in
> vf_fspp.c (fixes icc compilation).

IMO it would be nicer to make "temps" a local variable and refer to it
as an asm argument (using the "o" constraint). That would give
essentially the same resulting asm, except without the redundant
'subl/addl $n, %%"REG_SP"' instructions that are in your proposed patch.




More information about the MPlayer-dev-eng mailing list