[MPlayer-dev-eng] [PATCH] getch2() support for OS/2

Diego Biurrun diego at biurrun.de
Thu Feb 21 09:57:58 CET 2008


On Thu, Feb 21, 2008 at 11:59:25AM +0900, KO Myung-Hun wrote:
>
> Diego Biurrun wrote:
>>> I've added a comment to the patch.
>>
>> diego at cerebus:~/src/mplayer/mplayer$ patch --dry-run -p0 -i 
>> /tmp/getch2-os2.diff patching file mplayer.c
>> Hunk #1 succeeded at 2853 (offset -2 lines).
>> patching file osdep/getch2-os2.c
>> patch: **** malformed patch at line 220: Index: osdep/getch2.h
>>
>> The patch also does not take into account recent changes to getch2.h.
>
> Ok. I've resynced the patch with recent changes.

Not good enough:

diego at cerebus:~/src/mplayer/mplayer$ patch --dry-run -p0 -i /tmp/getch2-os2.diff 
patching file mplayer.c
patching file osdep/getch2-win.c
patching file osdep/getch2-os2.c
patch: **** malformed patch at line 233: Index: osdep/getch2.h

Also, please use a license header from drivers/*.

Diego



More information about the MPlayer-dev-eng mailing list