[MPlayer-dev-eng] [PATCH] fix to support file:///x:/path

Diego Biurrun diego at biurrun.de
Wed Feb 20 09:20:45 CET 2008


On Wed, Feb 20, 2008 at 04:07:22PM +0900, KO Myung-Hun wrote:
>
> Alban Bedel wrote:
>> On Wed, 20 Feb 2008 01:00:15 -0500
>> Rich Felker <dalias at aerifal.cx> wrote:
>>   
>>> On Wed, Feb 20, 2008 at 02:53:24PM +0900, KO Myung-Hun wrote:
>>>     
>>>> Currently, MPlayer supports file://path style. But on Windows and
>>>> OS/2, local path is expressed by 'file:///x:/path'. That is, '/' is
>>>> prefixed to normal path. So we need to remove '/' before 'x:/path'.
>>>>       
>>> To my knowledge, file://foo is always a relative (non-/-initial) path,
>>> i.e. file://foo means ./foo while file:///foo means /foo, at least in
>>> standard urls. I think MPlayer is just wrong here. Special-casing
>>> windows drive letter nastiness is not the right fix, at least..
>>
>> MPlayer work as you describe, it's not wrong :) Now how the path (ie.
>> everything after file://) is to be interpreted is obviously OS
>> dependend. So such "path fix" are acceptable imho but they must be under
>> #ifdef.
>
> Ok. I've updated the patch as your suggestion.

Applied.

Diego



More information about the MPlayer-dev-eng mailing list