[MPlayer-dev-eng] [PATCH] Color SPU rendering

[Benjamin Zores]

Ötvös Attila a écrit :
> Ezzel a dátummal: Thursday 31 January 2008 11.38.31 Reimar Döffinger ezt írta:
> 
> Hi Reimar Döffinger!
> 
>>>> I make color SPU patchset.
>>>>
>>>> This patchs support color spu in vo's (VOCTRL_COLOROSD_SUPPORT and draw
>>>> U,V planes if need/available).
>>> I modify: VOCTRL_COLOROSD_SUPPORT -> VOCTRL_QUERY_OSD_FORMAT
>>> and support some format.
>> Well, now the name is similar to VOCTRL_QUERY_FORMAT but the behaviour
>> is completely different! In addition it provides a much more limited
>> functionality, e.g. vo_gl will be able to trivially support RGB and BGR,
>> possibly even YUV for OSD, but with this design it can only report one
>> supported format!
>> This design also makes it very hard to add support e.g. to indicate
>> which OSD formats are fast and which are slow for a given vo (currently
>> there is no need for this though).
>> The most flexible system is like for the VOCTRL_QUERY_FORMAT: for the
>> given image format, return what functionality the VO can provide.
>> Currently probably only VFCAP_CSP_SUPPORTED and maybe VFCAP_ACCEPT_STRIDE
>> make sense for the OSD.
> 
> I am thinking, that VOCTRL_QUERY_OSD_FORMAT not necessary.
> 
> VOCTRL_QUERY_OSD_FORMAT -> VFCTRL_GET_OSD_FORMAT
> 
> Comment?

What's the status of this whole OSD patchset finally ?
Reimar, is it ok with you ?
Does anyone looked deeply at these patches ?

Ben