[MPlayer-dev-eng] [PATCH] vo_xvmc should not require colorkey

[Reimar Döffinger]

Hello,
On Sun, Feb 03, 2008 at 12:38:46PM +0200, Ivan Kalvachev wrote:
> On Feb 3, 2008 12:17 PM, Reimar Döffinger
> <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > newer nVidia cards (and probably others as well) do _not_ provide any
> > colorkey-functionality, but they can still do xvmc just fine.
> > While -nocolorkey is a possible workaround, I think it is too extreme to
> > fail xvmc initialization just because the colorkey can not be set.
> > If there are no objections I will apply in a few days.
> 
> Rejected.
> 
> Take a look of the x11_common.c::vo_xv_init_colorkey().
> If the graphic port doesn't support colorkey then it should not define
> attribute XV_COLORKEY, in that case the CK_METHOD_NONE is set, no
> extra drawing is done and the function completes with success.
> The same function already provides verbose (fatal actually) messages
> in case it fails.

Sorry, that was due to a local patch I had applied. I still find it
rather extreme to just fail in case something goes wrong with setting
the colorkey, but it causes no real problems currently.
So overall, I still think this change would be a good idea, but I will
not apply unless you tell me to.

Greetings,
Reimar Döffinger