[MPlayer-dev-eng] [PATCH] vo_xvmc should not require colorkey

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Feb 3 11:17:53 CET 2008


Hello,
newer nVidia cards (and probably others as well) do _not_ provide any
colorkey-functionality, but they can still do xvmc just fine.
While -nocolorkey is a possible workaround, I think it is too extreme to
fail xvmc initialization just because the colorkey can not be set.
If there are no objections I will apply in a few days.

Greetings,
Reimar Döffinger
-------------- next part --------------
Index: libvo/vo_xvmc.c
===================================================================
--- libvo/vo_xvmc.c	(revision 25948)
+++ libvo/vo_xvmc.c	(working copy)
@@ -622,7 +622,7 @@
 //take keycolor value and choose method for handling it
    if ( !vo_xv_init_colorkey() )
    {
-     return -1; // bail out, colorkey setup failed
+     mp_msg(MSGT_VO, MSGL_WARN, "Warning: Could not set colorkey\n");
    }
 
    vo_xv_enable_vsync();//it won't break anything


More information about the MPlayer-dev-eng mailing list