[MPlayer-dev-eng] [PATCH] support run command with specific osd_level

[Ulion]

2008/2/2, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sat, Feb 02, 2008 at 06:20:41PM +0800, Ulion wrote:
> > And clearly the osd_function's value is reset in the update_osd_msgs
> > function when osd_visible reached, and for frontend users did not want
> > osd of a seek action, the symbol should never changed to fast forward
> > or fast backward.
>
> This is another point of disagreement. I agree that it makes sense to
> not annoy the user with some OSD messages, but if the OSD is already
> displayed it IMO should never "lie" to the user.

then you should write code or patch to reset the osd_function's value
at somewhere when the osd bar code not get runned.

> This argument is somewhat less convincing in the case of the OSD
> percentage though.
> And I think you forgot the part that resets force_seek_osd_level to -1
> in your patch (unless I missed something).

Yes I missed it, my old patch reset it in command.c, but clearly it
should be reset after the seek action, fixed patch is here.

-- 
Ulion
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmd_with_osd_level5.diff
Type: text/x-vhdl
Size: 5812 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080202/e32281d0/attachment.bin>