[MPlayer-dev-eng] [PATCH] support run command with specific osd_level
albeu at free.fr
Fri Feb 1 17:22:54 CET 2008
On Fri, 01 Feb 2008 17:00:29 +0200
Uoti Urpala <uoti.urpala at pp1.inet.fi> wrote:
> On Fri, 2008-02-01 at 16:08 +0100, Alban Bedel wrote:
> > Then I would suggest adding commands to save/restore the value of a
> > property. That should be nearly trivial to implement, non hackish,
> > and could be useful for other things.
> That would not work for this use. If the OSD messages are generated
> normally no temporary change of osd_level gives the desired effect.
I see what you mean. As far as I can tell seeking is the only problem
as all the rest can be set via properties. Then perhaps we should just
add an extra parameter to the seek command to disable OSD interaction
for this particular seek.
> More generally I think adding save status inside MPlayer would be
> unnecessary complexity (and much more significant complexity than this
> OSD-specific patch).
Definitly not! I wrote nearly all the code related to this and I can
assure you that it would be at worst a small page of code to implement
push/pop for properties. All that is needed is to allocate some memory
and call the property functions to set/get from it. When I say trivial
I mean it.
> Similar functionality can be achieved by querying
> the value of the property, storing it on the controlling side and then
> later setting the property back to the queried value.
True enouth, however if such save/restore are requiered it is definitly
much simpler for frontends if they could just send a "self-contained"
More information about the MPlayer-dev-eng