[MPlayer-dev-eng] [PATCH] internal dvdnav

[Nico Sabbi]

Il giorno mer, 31/12/2008 alle 12.18 +0100, Reimar Döffinger ha scritto:
> On Wed, Dec 31, 2008 at 11:22:57AM +0100, Nico Sabbi wrote:
> > Il giorno mer, 31/12/2008 alle 09.47 +0100, Reimar Döffinger ha scritto:
> > > On Tue, Dec 30, 2008 at 04:50:25PM +0100, Reimar Döffinger wrote:
> > > > Hello,
> > > > with some more small changes to libdvdread and libdvdnav which are
> > > > currently pending, and these two new svn externals:
> > > > libdvdread svn://svn.mplayerhq.hu/dvdnav/trunk/libdvdread/src 
> > > > libdvdnav svn://svn.mplayerhq.hu/dvdnav/trunk/libdvdnav/src 
> > > > MPlayer can be built with (a working) embedded libdvdnav, and as far
> > > > as I can tell it will use the embedded libdvdcss, too.
> > > > A patch for that is attached.
> > > 
> > > The dvdread part that replaces our internal copy with an svn:externals
> > > entry is ready to be applied any time...
> > > I am in favour of doing this rather soon, even though I am not sure how
> > > well replacing an internal directory with and external will work,
> > > calling the new directory e.g. libdvdread4 might be safer.
> > > Any opinions?
> > 
> > I agree completely with the inclusion of both externals and with your
> > patch, but using different names is the only sane way to proceed: it
> > eliminates any ambiguity. 
> 
> Ok, I would then propose attached patch, to be applied in two steps,
> with the following additional externals:
> libdvdread4     svn://svn.mplayerhq.hu/dvdnav/trunk/libdvdread/src
> libdvdnav       svn://svn.mplayerhq.hu/dvdnav/trunk/libdvdnav/src
> 

OK, but you also need that -D flag as discussed in dvdnav-discuss