[MPlayer-dev-eng] [PATCH] fast_cmov should be set on x86_64

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Fri Dec 26 12:20:36 CET 2008


On Fri, Dec 26, 2008 at 07:06:29PM +0800, Zuxy Meng wrote:
> 2008/12/24 Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > On Wed, Dec 24, 2008 at 05:47:54PM +0800, Zuxy Meng wrote:
> >> Hmmm so we don't care for those who bought a 64-bit P4.
> >
> > At the expense of everyone else who made sane buying decisions?
> > Certainly not!
> 
> Intel has so far shipped only Family 6 and Family 15 64-bit CPUs so if
> it isn't a core2 it must be a P4.

That's certainly not entirely right, there is the i7, too (I have no
idea if that is family 6 or not, which is why I won't fiddle with it
since the new code works right for everything except P4 an probably any
future CPU).
Also note that the previous code had fast_cmov _always disabled_, which
is why I changed it. I guess nothing speaks against making the code
consistent with the 32 bit case and disable fast_cmov for family 15
CPUs, but given that the previous code was definitely broken, and I can
not test P4 and don't care, how about just reviewing an testing the
patch I proposed? Because if nobody does that I think I was right not to
care about P4.



More information about the MPlayer-dev-eng mailing list