[MPlayer-dev-eng] [PATCH] Replaced deprecated QuickDraw calls in vo_quartz

Guillaume POIRIER poirierg at gmail.com
Sun Dec 14 23:57:43 CET 2008


Hello,

2008/10/29 Gregor Riepl <onitake at gmail.com>:

> here's the updated patch. i also removed QuitApplicationEventLoop from
> osdep/macosx_finder_args.c, as it's gone for 64bit and the docs say it's
> normally not neccessary.
> for some reason, there's a regression here, though: the quit menu item
> doesn't work (other menu entries and cmd-q do), but it doesn't work with
> QuitApplicationEventLoop either, so that looks unrelated.

For the record, here's what Apple's doc has to say about this function:
QuitApplicationEventLoop

Terminates the application event loop.

void QuitApplicationEventLoop (
   void
);

Discussion

This function is used to quit the
RunApplicationEventLoop<file:///Developer/Documentation/DocSets/com.apple.ADC_Reference_Library.CoreReference.docset/Contents/Resources/Documents/documentation/Carbon/Reference/Carbon_Event_Manager_Ref/Reference/reference.html#//apple_ref/c/func/RunApplicationEventLoop>
function.
Typically, your application doesn't need to call this. If your application
has the Quit menu item tagged with the kHICommandQuit menu command ID, the
toolbox will automatically call this for your application, automatically
terminating your event loop. If your application wants to do pre-processing
before the event loop exits, it should intercept either the kHICommandQuit menu
command, or the kEventAppQuit event.
Availability

   - Available in Mac OS X v10.0 and later.
   - Not available to 64-bit applications.

Declared InCarbonEvents.h



I don't see further reason to not remove that call now.

Guillaume
-- 
Only a very small fraction of our DNA does anything; the rest is all
comments and ifdefs.

Stephen Leacock  - "I detest life-insurance agents: they always argue that I
shall some day die, which is not so."



More information about the MPlayer-dev-eng mailing list