[MPlayer-dev-eng] Direct3D OSD discussion

[Reimar Döffinger]

On Mon, Dec 08, 2008 at 12:00:52PM +0000, Jim Hauxwell wrote:
> It should never go outside the texture area when generating the OSD

While that is true you fall back to using the whole texture, which i
think is as in your very first patch, so the aspect issue should arise
again.
Setiing max_texture_width to 256 should help you see the issue if I am right.

> @@ -397,7 +500,7 @@
>      /* If we're here, then we should lock the rect and copy a packed frame */
>      if (!priv->locked_rect.pBits) {
>          if (FAILED(IDirect3DSurface9_LockRect(priv->d3d_surface,
> -                                              &priv->locked_rect, NULL, 0))) {
> +                                              &priv->locked_rect, NULL, D3DLOCK_DISCARD))) {
>              mp_msg(MSGT_VO, MSGL_ERR, "<vo_direct3d>Surface lock failure\n");
>              return VO_ERROR;
>          }

Unrelated. If that is intentional and you explain the why i can make
this change, you don't need to send a separate patch.

> @@ -530,9 +636,34 @@
>      /* Store in priv->desktop_fmt the user desktop's colorspace. Usually XRGB. */
>      priv->desktop_fmt = disp_mode.Format;
>  
> -    mp_msg(MSGT_VO, MSGL_V, "disp_mode.Width %d, disp_mode.Height %d\n",
> +    mp_msg(MSGT_VO, MSGL_V, "<vo_direct3d>disp_mode.Width %d, disp_mode.Height %d\n",
>             disp_mode.Width, disp_mode.Height);

Unrelated, remind me to fix it (at the latest) after the OSD was applied if I forget.

Greetings,
Reimar Döffinger