[MPlayer-dev-eng] Video output for RV280+Mesa3D

[Diego Biurrun]

On Fri, Dec 05, 2008 at 01:44:51PM +0300, malc wrote:
> 
> The patch implements the most performant(at least on this mac mini) way to
> put YV12/I420/YUY2/UYVY data on screen. Constraints include:
> a) PPC
> b) Altivec presence
> c) Mesa3D + GLX_MESA_allocate_memory
> d) Horizontal resolution being multiple of 16
> 
> The code also relies on SDL for operation.
> 
> --- libvo/vo_rv280.c	(revision 0)
> +++ libvo/vo_rv280.c	(revision 0)
> @@ -0,0 +1,732 @@
> +#define GL_GLEXT_PROTOTYPES
> +#define GLX_GLXEXT_PROTOTYPES

This is missing a license header

> +void mplayer_put_key(int code);

Please #include mp_fifo.h instead.

> +/*
> + * AltiVec-enhanced yuv2yuvX
> + *
> + * Copyright (C) 2004 Romain Dolbeau <romain at dolbeau.org>
> + * based on the equivalent C code in "postproc/swscale.c"

You mean libswscale/swscale.c?

> +/*
> + * AltiVec-enhanced yuv2yuvX
> + *
> + * Copyright (C) 2004 Romain Dolbeau <romain at dolbeau.org>
> + * based on the equivalent C code in "postproc/swscale.c"

ditto

I think this code should be added to libswscale if it is really faster.

> +static void flip_page (void)

Sometimes you put a space before the opening parenthesis, sometimes you
don't.  Leave it out.

> --- configure	(revision 28089)
> +++ configure	(working copy)
> @@ -4891,6 +4891,10 @@
>      _vomodules="sdl $_vomodules"
>      _aomodules="sdl $_aomodules"
>      _res_comment="using $_sdlconfig"
> +  if test "$_gl" = yes && linux && ppc ; then
> +    _def_rv280="#define HAVE_RV280 1"
> +    _rv280="yes"
> +  fi
>    else
>      _def_sdl='#undef CONFIG_SDL'
>      _novomodules="sdl $_novomodules"

I think it should be possible to enable this separately.

Diego