[MPlayer-dev-eng] Direct3D OSD discussion

Diego Biurrun diego at biurrun.de
Sat Dec 6 10:48:27 CET 2008


On Sat, Dec 06, 2008 at 08:53:33AM +0000, Jim Hauxwell wrote:
> 
> From my patch the other day, I noticed some variables had capital
> letters at the start, so I've fixed this.
> 
> --- libvo/vo_direct3d.c	(revision 28089)
> +++ libvo/vo_direct3d.c	(working copy)
> @@ -100,6 +116,13 @@
>  
> +typedef struct vertex_s {
> +    float x, y, z;      /* Position of vertex in 3D space */
> +    float tu, tv;       /* Texture coordinates */
> +} vertex_t;

The _t namespace is reserved by POSIX, so please use something else.

> @@ -213,6 +247,75 @@
> +
> +    mp_msg(MSGT_VO, MSGL_V, "<vo_direct3d><INFO>surface (%d, %d) requested = (%d, %d)\n",
> +        vo_dwidth, vo_dheight, priv->osd_texture_width, priv->osd_texture_height);

Indent the second line to be aligned with the rest of the text within
the parentheses, same below.

Diego



More information about the MPlayer-dev-eng mailing list