[MPlayer-dev-eng] [PATCH] OSD timestamp

[Diego Biurrun]

On Wed, Dec 03, 2008 at 09:23:34PM +0100, Ötvös Attila wrote:
> 
> I update my OSD timestamp patch.

some comments below..

> --- libvo/sub.h	(revision 28082)
> +++ libvo/sub.h	(working copy)
> @@ -112,6 +113,11 @@
>  extern int spu_alignment;
>  extern int spu_aamode;
>  extern float spu_gaussvar;
> +#ifdef CONFIG_OSDTIME
> +extern char *osdtime;
> +extern int osdtimevmargin;
> +extern int osdtimehmargin;
> +#endif

pointless #ifdef

> @@ -124,6 +130,9 @@
>  int vo_osd_changed(int new_value);
>  int vo_osd_check_range_update(int,int,int,int);
>  void free_osd_list(void);
> +#ifdef CONFIG_OSDTIME
> +int vo_osdtime(void);
> +#endif

ditto

> --- libvo/sub.c	(revision 28082)
> +++ libvo/sub.c	(working copy)

All of this looks terribly cramped and could use some whitespace.

> --- configure	(revision 28082)
> +++ configure	(working copy)
> @@ -282,6 +282,7 @@
>    --disable-w32threads   disable Win32 threads support [autodetect]
>    --disable-ass          disable internal SSA/ASS subtitle support [autodetect]
>    --enable-rpath         enable runtime linker path for extra libs [disabled]
> +  --disable-osdtime      disable OSD time, date and info text support [autodetect]

That's not a good place for this option, place it near the other OSD
options.

> @@ -8249,6 +8273,7 @@
>  $_def_termcap
>  $_def_termios
>  $_def_vsscanf
> +$_def_osdtime

This was previously in alphabetical order.

> --- DOCS/man/en/mplayer.1	(revision 28082)
> +++ DOCS/man/en/mplayer.1	(working copy)
> @@ -2303,6 +2303,103 @@
>  .PD 1
>  .
>  .TP
> +.B \-osdtime "[t|b[l|c|r]]\_<format string>"
> +Mplayer has an onscreen display (OSD) for date, time and info text.

You are not allowed to misspell MPlayer, ever.

> +switch horizontal align: left -> center -> right -> left ...

alignment, same below

> +.B \-osdtime-hmargin "<0-100>"
> +Set horizontal (left and right) margin in pixel (default: 10).

pixels, same below

Diego