[MPlayer-dev-eng] [PATCH] use pthreads for cache on cygwin

David DeHaven dave at sagetv.com
Tue Dec 2 17:30:34 CET 2008


>>> It is never used for pthread. It's always a good idea to svn up  
>>> before
>>> making patches.
>>
>> No, I just made a bad assumption. I used it to make sure the thread
>> terminated properly in my implementation.
>
> I know, I considered doing something like that. But the thing is, at
> least on Windows there is (AFAICT) no way to forcibly terminate a  
> thread without
> leaking memory, and even everywhere else it is a bad idea.

Ah, no, I didn't force it to terminate, I've never had luck with that  
myself (though I have used pthread_join in the past). I've had so many  
issues with deadlocking and race conditions in multithreaded apps that  
I tend to spin the main thread until the thread terminates (using  
flags) to make sure it's dead, but it terminates itself. I did that  
here because there was some condition that would cause a deadlock when  
trying to terminate the app, I don't know if that's still the case or  
not. We'll find out as soon as it's done building.

-DrD-




More information about the MPlayer-dev-eng mailing list