[MPlayer-dev-eng] [PATCH] Patch for better pause support.

[Robert Cummings]

On Tue, 2008-08-26 at 19:57 +0200, Reimar Döffinger wrote:
> On Mon, Aug 25, 2008 at 02:09:18PM -0400, Robert Cummings wrote:
> > On Thu, 2008-08-07 at 12:39 +0200, Reimar Doeffinger wrote:
> > >
> > > The basic idea seems sound, the implementation has a few rough edges though
> > > like duplicating some of the code in the while(). I am also unsure if/how
> > > this could be extended to handle get_property/set_property etc. properly.
> > > Unless someone else steps up to work on it, you will have to wait until
> > > I again have internet at home (probably around August 12th).
> > 
> > *bump* :)
> 
> Ok, my problem is do not know what exactly 90 % of the code is there
> for,

90% of which code? The code I added?

>  how much of it is possibly workarounds for bugs elsewhere etc.
> That's what attached patch is for, I'd like to know what problems
> there are with it (someone testing the dvdnav mouse support with that
> change probably is a good idea), particularly if you consider any
> critical (if not, I'd find it preferable to apply that and work forward
> from there).
> Also I think it might be better to let the user always select this
> "mode" explicitly (possibly with another pausing_... prefix).

Sure, I can add another pausing_ prefix... name might be weird... maybe
pausing_how_you_would_expect ;) I'll try and do a patch that way this
weekend when I free up some time.

Cheers,
Rob.
-- 
http://www.interjinn.com
Application and Templating Framework for PHP