[MPlayer-dev-eng] [RFC] Color management filter

[Yue Shi Lai]

Reimar Döffinger schrieb:
> Also that should be const (though you will have to fix the asm
> constraints for that I think).

I forgot to comment on this issue: It really doesn't matter.

You have to load XMM register by memory pointer anyway. So even if you 
pass by pointer and with the "r" constraint, thus circumventing the 
compiler requirement to have a non-const "m" arguments, nothing prevents 
you from modifying the contents of these static arrays - there is simply 
no const in assembly. The only thing you did is to trick the compiler in 
thinking that nothing happened.

On the other hand, I think "r" constraints tend to trigger unnecessary 
copying of addresses to and from registers, and is a bad idea if you are 
already occupying almost all GP registers.

Best,

Yue Shi Lai