[MPlayer-dev-eng] [FFmpeg-devel] [PATCH] remove useless math.h include in libavutil/mathematics.h

[Reimar Döffinger]

On Tue, Aug 26, 2008 at 08:00:12PM +0200, Reimar Döffinger wrote:
> On Mon, Aug 25, 2008 at 09:15:29PM +0200, Guillaume POIRIER wrote:
> > Index: liba52/parse.c
> > ===================================================================
> > --- liba52/parse.c	(revision 27478)
> > +++ liba52/parse.c	(working copy)
> > @@ -32,12 +32,12 @@
> >  #include <string.h>
> >  #include <inttypes.h>
> > 
> > +#include "libavutil/avutil.h"
> >  #include "a52.h"
> >  #include "a52_internal.h"
> >  #include "bitstream.h"
> >  #include "tables.h"
> >  #include "mm_accel.h"
> > -#include "libavutil/avutil.h"
> > 
> >  #ifdef HAVE_MEMALIGN
> >  /* some systems have memalign() but no declaration for it */
> > 
> > 
> > did the trick as well.
> > Reimar, what do you think about that change?
> 
> Bad idea, if there is code duplicated with libavutil it should at least
> be kept in sync.
> IMO the always_inline define should be completely removed and replaced
> with a libavutil/common.h include if possible.

To be honest, I do not even know if it is really worth keeping the
always_inline, just using "inline" might be good enough.