[MPlayer-dev-eng] [PATCH] PNG_ENCODER needed for vf_screenshot with --disable-mencoder

Diego Biurrun diego at biurrun.de
Tue Aug 12 09:09:58 CEST 2008


On Tue, Aug 12, 2008 at 10:37:01AM +0900, Magnus Damm wrote:
> On Mon, Aug 11, 2008 at 6:16 PM, Magnus Damm <magnus.damm at gmail.com> wrote:
> > On Mon, Aug 11, 2008 at 3:38 AM, Diego Biurrun <diego at biurrun.de> wrote:
> >> On Sun, Aug 10, 2008 at 03:22:49PM +0200, Adrian Stutz wrote:
> >>> When compiling mplayer without mencoder, only mpeg1 and snow encoders are
> >>> included.
> >>> The png encoder is missing, which is needed for vf_screenshot.
> >>
> >> Applied.  Next time please attach patches, your mailer mangles them.
> >
> > This patch breaks building without zlib. Revision 27448 is broken,
> > 27441 builds just fine for me.
> >
> > The header file check for zlib is done early, but PNG_ENCODER is set
> > regardless the result of that check. Not sure how to fix that in a
> > clean way.

The clean way to fix that would be to stop (badly) duplicating FFmpeg's
configure in ours...

> Anyway, here's a patch to fix the build problem the ugly way.

Applied a slightly shorter version.

Diego



More information about the MPlayer-dev-eng mailing list