[MPlayer-dev-eng] [PATCH] Remove redundant XShmGetEventBase declaration

[Reimar Doeffinger]

On Tue, Aug 12, 2008 at 05:23:35AM +0000, Bryan Henderson wrote:
> BTW does it really matter?  Missing this declaration probably just
> adds a drop to the ocean of compile warnings.  That would explain why
> I with my 4.0.2 haven't noticed a problem with the other
> declaration-less references to which Diego refers.

It is a problem e.g. with x86_64 (assuming that version even works there)
and can cause problems at runtime.
Of course if there was a compiler flag for gcc to simply die if a used function
is missing a declaration this would be much nicer.
But given the declaration was not consequently present IMO is a clear indication that
1) the way it was done is just not maintainable
2) it creates inconsistent behaviour that does make debugging not any easier
I have not checked, but I guess the simplest "solution" is to disable XShm if Xf < 4.2
is detected (assuming there is alread auto-detection for XShm).