[MPlayer-dev-eng] [PATCH] Remove redundant XShmGetEventBase declaration

Diego Biurrun diego at biurrun.de
Mon Aug 11 21:05:27 CEST 2008


On Mon, Aug 11, 2008 at 11:03:06AM +0200, Attila Kinali wrote:
> On Mon, 11 Aug 2008 02:49:27 +0300
> Uoti Urpala <uoti.urpala at pp1.inet.fi> wrote:
> 
> > On Mon, 2008-08-11 at 01:31 +0200, Attila Kinali wrote:
> > > Uhm... have you seen that little "if" up there?
> > > It means, if and only if there are still systems around
> > > that do not declare XShmGetEventBase in the header file,
> > > then, and only then there should be a configure check.
> > > And as MIT-SHM is old (as in very old), i doubt that any
> > > such system exists.
> > > 
> > > I just checked the appropriate documentation, and 
> > > MIT-SHM is in X since at least X11R5 (which means 1994!),
> > > the document is even dated 1991! This means it's nearly 10 years
> > > older than MPlayer. So, i really doubt that there is any
> > > sytem around that would still need that declaration hack at all.
> > 
> > Ivan's post from last Thursday did finally name a system without the
> > declaration: XFree86 4.1 (I haven't checked whether that's accurate).
> 
> I just checked this. XF86 4.1.0 has a "broken" headerfile that
> does not contain XShmGetEventBase, it has been fixed in December 2001
> and released with XF86 4.2.0 in June 2002.

Interestingly, 4.1.0 is not mentioned on the XFree86 news page.  Was
that release so bad in other aspects as well?

Diego



More information about the MPlayer-dev-eng mailing list