[MPlayer-dev-eng] [PATCHES] vidix: SuperH fixes, NV12 support, new vidix driver

Magnus Damm magnus.damm at gmail.com
Mon Aug 11 11:47:12 CEST 2008


On Fri, Aug 8, 2008 at 8:50 PM, Benjamin Zores <ben at geexbox.org> wrote:
> Ok, I've reviewed it quickly and I confirm that 2.6.27+ is runtime
> dependancy only has it just tries to read /sys/... file.
>
> Though, I think that configure needs to ensure that only Linux target
> will build the driver (like it's done for ivtv vidix driver) and
> preferably only when building for sh arch.
>
> I have no other objection regarding the vidix patch itself, except that
> I'd rather have seen snprintf() than sprintf() wherever it's possible.

Thanks for your review. I agree. I'll post V3 in a little while.

/ magnus



More information about the MPlayer-dev-eng mailing list