[MPlayer-dev-eng] [PATCH] Remove redundant XShmGetEventBase declaration

Attila Kinali attila at kinali.ch
Mon Aug 11 01:31:54 CEST 2008


On Mon, 11 Aug 2008 01:02:32 +0300
"Ivan Kalvachev" <ikalvachev at gmail.com> wrote:

> On 8/7/08, Attila Kinali <attila at kinali.ch> wrote:
> > [...]
> > And yes, if XShmGetEventBase is not declared on all systems (...),
> > then there should be a configure time check for it.
> 
> I'm sure you understood quite well my request 
> that your patch must contains configure check,
> as your reply is:

Uhm... have you seen that little "if" up there?
It means, if and only if there are still systems around
that do not declare XShmGetEventBase in the header file,
then, and only then there should be a configure check.
And as MIT-SHM is old (as in very old), i doubt that any
such system exists.

I just checked the appropriate documentation, and 
MIT-SHM is in X since at least X11R5 (which means 1994!),
the document is even dated 1991! This means it's nearly 10 years
older than MPlayer. So, i really doubt that there is any
sytem around that would still need that declaration hack at all.

			Attila Kinali
-- 
The true CS students do not need to know how to program.
They learn how to abstract the process of programming to
the point of making programmers obsolete.
		-- Jabber in #holo



More information about the MPlayer-dev-eng mailing list