[MPlayer-dev-eng] [PATCHES] vidix: SuperH fixes, NV12 support, new vidix driver

[Magnus Damm]

On Thu, Aug 7, 2008 at 8:35 PM, Diego Biurrun <diego at biurrun.de> wrote:
> On Thu, Aug 07, 2008 at 08:21:10PM +0900, Magnus Damm wrote:
>>
>> Patch 1 - SuperH configure changes and vidix build fixes.
>> Vidix doesn't build on SuperH and the configure script doesn't support
>> sh4 and sh4a at the moment.
>
> configure part of this patch is OK.

Good, thanks. Want me to break this patch into two parts?
Any idea what to do about the vidix build issue? That part of the
patch looks like crap regardless how I twist and turn the bits.

>> Patch 3 - Add new sh_veu vidix driver.
>> Adds a new vidix driver for the VEU hardware block found in SuperH
>> Mobile processors.
>
>> --- 0001/Makefile
>> +++ work/Makefile     2008-08-07 19:32:24.000000000 +0900
>> @@ -597,6 +597,7 @@ SRCS_MPLAYER-$(VIDIX_RADEON)        += v
>>  SRCS_MPLAYER-$(VIDIX_S3)            += vidix/s3_vid.c
>>  SRCS_MPLAYER-$(VIDIX_SIS)           += vidix/sis_vid.c vidix/sis_bridge.c
>> +SRCS_MPLAYER-$(VIDIX_SH_VEU)        += vidix/sh_veu_vid.c
>>  SRCS_MPLAYER-$(VIDIX_UNICHROME)     += vidix/unichrome_vid.c
>
> Please respect alphabetical order here and everywhere else.

Will do.

>> --- /dev/null
>> +++ work/vidix/sh_veu_vid.c   2008-08-07 19:32:24.000000000 +0900
>> @@ -0,0 +1,598 @@
>> + * You should have received a copy of the GNU General Public License
>> + * along with MPlayer; if not, write to the Free Software
>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>> + *
>> + */
>
> nit: unnecessary blank line
>
> For new files please use 4 spaces indentation, no tabs and avoid
> trailing whitespace.

Gotcha.

>> +#if 0
>> +     printf("sh_veu: scale %s mant %ld, frac %ld, rep %ld, crop %d\n",
>> +            vertical ? "vert" : "horiz", mant, frac, rep, crop_out);
>> +#endif
>
> Debugging leftover?

Yeah, i thought it was handy for future debugging. But I may as well remove it.

Thanks for your help. I'll repost a V3 within a day or two.

/ magnus