[MPlayer-dev-eng] [PATCH] Remove redundant XShmGetEventBase declaration

Diego Biurrun diego at biurrun.de
Thu Aug 7 13:39:46 CEST 2008


On Thu, Aug 07, 2008 at 11:15:55AM +0200, Attila Kinali wrote:
> On Sat, 2 Aug 2008 21:42:22 +0300
> "Ivan Kalvachev" <ikalvachev at gmail.com> wrote:
> 
> > On 8/2/08, Diego Biurrun <diego at biurrun.de> wrote:
> > > Here is a patch to remove a redundant XShmGetEventBase declaration from
> > > libvo/vo_x11.c and libvo/vo_xvmc.c, which dates back to r2(!).  If this
> > > is really a problem, there should be a proper check in configure, not a
> > > hackish declaration duplicated over multiple files.
> > 
> > Rejected.
> 
> May i ask why you reject the patch?

I do not feel in any way bound by one-word rejection messages.  I have
given reasons, Ivan has not.

> Is there anything technicaly wrong or is it just because
> it's Diego who wrote it?

It's the latter.  None of the reasons I gave have been addressed.

Diego



More information about the MPlayer-dev-eng mailing list