[MPlayer-dev-eng] [PATCH] Remove redundant XShmGetEventBase declaration
uoti.urpala at pp1.inet.fi
Wed Aug 6 22:36:30 CEST 2008
Declaring symbols that are expected to exist in external libraries with
our own prototypes in MPlayer .c files is wrong by default unless there
is special justification. So far there has been no evidence it would be
justified any more, if it ever was.
On Wed, 2008-08-06 at 15:59 -0400, compn wrote:
> you could ask iive to test your patch and see if it breaks on his system.
> instead of threatening to commit and ignoring his maintainership.
Diego did post the patch in advance and Ivan has had lots of time to
post reasons why the declaration would still be needed if he knows of
> but i'm guessing you two are too busy fighting to talk to each other.
I don't see what Diego could have done significantly differently.
Removing such a questionable declaration is reasonable unless there is
special reason not to; as far as I can see Diego did search for
potential reasons, and given how old it is its mere existence is no
indicator that it would be there for a good reason.
If Ivan knew of any systems where the declaration would (still) be
beneficial then he should have told what they were.
> or just commit vo_x11 hunk, and ignore xvmc. i dont see any vo maintainers reject/approve vo_x11 patch either.
Either the systems lack the declaration when compiling both VOs, or when
compiling neither. Leaving the declaration in one VO makes little sense.
If Ivan knows of systems where the declarations are needed he should say
so; if they're not needed then they should be removed from all VOs and
Ivan's pointless complaints should be ignored.
More information about the MPlayer-dev-eng