[MPlayer-dev-eng] [PATCH] Remove redundant XShmGetEventBase declaration

[Diego Biurrun]

On Wed, Aug 06, 2008 at 08:44:24AM -0400, compn wrote:
> On Wed, 6 Aug 2008 09:05:58 +0200, Diego Biurrun wrote:
> >On Tue, Aug 05, 2008 at 08:26:22PM -0400, compn wrote:
> >> On Sat, 2 Aug 2008 19:58:39 +0200, Diego Biurrun wrote:
> >> >Index: libvo/vo_x11.c
> >> >Index: libvo/vo_xvmc.c
> >> 
> >> patch missing configure check for removed declaration. rejected.
> >
> >There is no configure check to begin with.  That's the whole point.
> 
> but you are removing a useful hack, without fixing it.

s/useful//

May I suggest that you reread the rationale you snipped?

There has never been a configure check to begin with.
This function prototype is duplicated over the code without any
assurance that the underlying libraries actually support them.
Should the function call not be supported, the failure would
just be moved from compile time to link time, which is bad.

There is no indication where this declaration was ever missing on any
system except for the cryptic comment above it.  Log messages do not
enlighten us, neither does Google.  We do not know which systems are
affected.  In short, it is a mess and it is time to remove it.

To top it off, the function is used in other files without a check or
function prototype anywhere.  It has never caused any trouble
apparently.  It is a workaround for a broken system at best.  It is time
to remove it.

> it might break the systems referred to.

No systems are referred to anywhere, hence it will not break any.

> did you even test it on a system with xvmc?

I compile my test tree with xvmc enabled.

Diego