[MPlayer-dev-eng] [PATCH] Remove redundant XShmGetEventBase declaration

[compn]

On Wed, 6 Aug 2008 09:13:46 +0200, Diego Biurrun wrote:
>On Tue, Aug 05, 2008 at 07:57:36PM -0400, compn wrote:
>> On Tue, 5 Aug 2008 23:38:45 +0200, Diego Biurrun wrote:
>> >On Sat, Aug 02, 2008 at 07:58:39PM +0200, Diego Biurrun wrote:
>> >> Here is a patch to remove a redundant XShmGetEventBase declaration from
>> >> libvo/vo_x11.c and libvo/vo_xvmc.c, which dates back to r2(!).  If this
>> >> is really a problem, there should be a proper check in configure, not a
>> >> hackish declaration duplicated over multiple files.
>> >
>> >Will apply on the weekend.
>> 
>> then you will be breaking rule 5 and 9 since iive has already
>> rejected it for vo_xvmc.
>> 
>> rule 5 explicitly forbids this.
>> "The same applies to compiler warning fixes, trivial looking fixes and
>> to code maintained by other developers."
>> "Send your changes as patches to the mplayer-dev-eng mailing list, and
>> if the code maintainers say OK, you may commit."
>
>There is no provision in there on how to deal with recalcitrant and
>uncooperative "maintainers".  Besides, it is my opinion that this is a
>build system issue.

i noticed this. i propose a rule that says project leader can override a maintainer on any particular piece of code.

of course mplayer does not have a project leader, but thats another thread.
one step at a time please!

as for build issue, you will have to prove it errors out on a users' system before you can take further action imo. since its been there since r2, i think you will have a hard time with that. 

>> rule 9 says "actively maintained" and iive reviews vo_xvmc patches so
>> i believe its active.
>
>I don't remember a review, much less a timely one.  All of the XVMC
>stuff has had known issues for many years, none of which were ever
>addressed, even though there were promises to do so.  In my book, this
>is incompatible with any interpretation of the term "actively
>maintained".

are these bugs documented somewhere? a quick search on bugzilla returns 0.

are there any unreviewed patches? iive rejected the last xvmc patch i remember (unichrome xvmc).
http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2008-February/056433.html

i'm not expressly trying to argue with anyone, just trying to organize bugs/samples/patches.

-compn