[MPlayer-dev-eng] [PATCH] Remove redundant XShmGetEventBase declaration
tempn at twmi.rr.com
Wed Aug 6 01:57:36 CEST 2008
On Tue, 5 Aug 2008 23:38:45 +0200, Diego Biurrun wrote:
>On Sat, Aug 02, 2008 at 07:58:39PM +0200, Diego Biurrun wrote:
>> Here is a patch to remove a redundant XShmGetEventBase declaration from
>> libvo/vo_x11.c and libvo/vo_xvmc.c, which dates back to r2(!). If this
>> is really a problem, there should be a proper check in configure, not a
>> hackish declaration duplicated over multiple files.
>Will apply on the weekend.
then you will be breaking rule 5 and 9 since iive has already
rejected it for vo_xvmc.
rule 5 explicitly forbids this.
"The same applies to compiler warning fixes, trivial looking fixes and to code maintained by other developers."
"Send your changes as patches to the mplayer-dev-eng mailing list, and if the code maintainers say OK, you may commit."
rule 9 says "actively maintained" and iive reviews vo_xvmc patches so i believe its active.
More information about the MPlayer-dev-eng