[MPlayer-dev-eng] [PATCH] select audio/sub tracks based on 'default' attribute

Evgeniy Stepanov eugeni.stepanov at gmail.com
Wed Apr 30 16:05:02 CEST 2008


On Wednesday 30 April 2008 16:52:47 Sergey Malkovsky wrote:
> > I think the problem is not with 'default' tracks, but with subtitle
> > selection method as a whole.
>
> Agreed.
>
> >  Having priorities would be good, there is even no need for an option,
> > the following seems ok for most uses:
> >  external -> internal -> auto-external.
> >  It surely makes sense to display the subtitles user specified with -sub
> > first.
>
> IMHO, highest priority must be set for external subtitles (chosen by
> -sub options). If there is no such option,  player must show us
> auto-external subs (if there are any). And only after that player must
> check -slang option.

Sounds good. All external subtitles should probably go before internal ones, 
because it is usually user's decision to put them there (for auto- subs) or 
to add -sub option; while internal subtitles are a decision of some other, 
remote person and can not be easily removed.

> If it presents and mkv file have subtitles with 
> chosen language id, player must show chosen subtitles. Internal
> subtitles that have "default" mark must be at the least.
>
> In the current version of player "default" internal mkv subtitles have
> highest priority.
>
> I think - if user provides no any language id, or internal sub track
> language id is not equal to provided, player shouldn't show any
> "default" internal sub (or option to disable mkv subs at all must be
> added  first).

Why? That's exactly what default track attribute is for: to select a track if 
no other criterion could be applied. Of course, it should be given minimal 
priority. To completely disable all subtitles one can use -nosub option.



More information about the MPlayer-dev-eng mailing list