[MPlayer-dev-eng] vo_gl PBO patch ..

[Sven Gothel]

On Tuesday 29 April 2008 13:31:50 Reimar Döffinger wrote:
> On Tue, Apr 29, 2008 at 01:11:35PM -0600, Sven Gothel wrote:
> > To do the unification, one more question ..
> > 
> > Why is that orig Upload function so complicated ?
> > I might miss something here completly, but IMHO:
> > 
> > +++
> >   glAdjustAlignment(stride);
> >   glPixelStorei(GL_UNPACK_ROW_LENGTH, stride / glFmt2bpp(format, type));
> >   for (; y + slice <= y_max; y += slice) {
> >     glTexSubImage2D(target, 0, x, y, w, slice, format, type, data);
> >     data += stride * slice;
> >   }
> >   if (y < y_max)
> >     glTexSubImage2D(target, 0, x, y, w, y_max - y, format, type, data);
> > +++
> > 
> > equals to just:
> > 
> > +++
> >   glAdjustAlignment(stride);
> >   glPixelStorei(GL_UNPACK_ROW_LENGTH, stride / glFmt2bpp(format, type));
> >   glTexSubImage2D(target, 0, x, y, w, h, format, type, data);
> > +++
> 
> 
> Functionality-wise, yes they are the same. Speed-wise not (necessarily).
> In tests long ago on a TNT 2 code above could be almost 5% faster.

Good. I gues that's history now and related to the texture xfer technique.

So, one may use pbodma now ..

A revised review is coming up, indeed, it looks much simpler now.

Thank you.

Cheers, Sven

> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> 



-- 
health & wealth
mailto:sgothel at jausoft.com ; www  : http://www.jausoft.ca ; pgp: http://www.jausoft.com/gpg/
land : +1 (780) 637 3842 ; cell: +1 (780) 952 4481
Timezone MST: EST-2, UTC-7, CET-8 ; MDT: EDT-2, UTC-6, CEDT-8