[MPlayer-dev-eng] [PATCH] MSU Codec and vd_vfw change fixing seg fault

[Reimar Döffinger]

On Sun, Apr 20, 2008 at 11:28:19PM +0200, Roberto Togni wrote:
> On Fri, 11 Apr 2008 06:09:27 -0400
> AsSlowAsHell <asslowashell at gmail.com> wrote:
> 
> > -Added info in codecs.conf to support MSU Screen Capture Lossless Codec
> > -Changed the call to ICDecompress video for windows API to pass output
> > buffer even if frame drop is true.  Certain codecs like MSU seem to
> > write to the output buffer even if told to frame skip and this was
> > causing a memory write to 0x00000000.
> 
> Applied the codecs.conf part of the patch, and added two dummy
> functions to win32.c to remove some calls to unk_ functions (they are
> some constructor/destructor for c++ stuff).
> From the name (std::_Lockit) and by looking on the net it's probably
> related to memory locking in multithread dll for ms c++, so it would be
> nice if somebody with a multi-core cpu can test it (on 32-bit os that
> uses the loader, in windows should be ok).

While I agree with testing, our loader always returns 1 as number of
CPUs/cores, which should make it less likely to be a problem.

Greetings,
Reimar Döffinger