[MPlayer-dev-eng] Indentation style (was: [PATCH] Fix useless dependencies in the stream lib)

Alban Bedel albeu at free.fr
Thu Apr 10 11:03:53 CEST 2008


On Thu, 10 Apr 2008 02:15:30 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> On Thu, Apr 10, 2008 at 02:30:55AM +0200, Alban Bedel wrote:
> > On Wed, 9 Apr 2008 18:33:11 -0400
> > Robert Henney <robh at rut.org> wrote:
> > 
> > > On Wed, Apr 09, 2008 at 03:54:45PM +0200, Alban Bedel wrote:
> > > > On Wed, 9 Apr 2008 10:15:52 +0200
> > > > Diego Biurrun <diego at biurrun.de> wrote:
> > > > 
> > > > > That sums it up nicely for me.  Albeu, your goal is noble,
> > > > > but you could instead try to convince people to go for a
> > > > > single consistent style.
> > > > 
> > > > I'll try nothing. I just hoped we could get a somewhat nicer
> > > > work environment.
> > > 
> > > The environment you seem to want for yourself may be possible
> > > without needing "magic comments" within the source tree.  I
> > > believe, although haven't investigated, that the same editor
> > > parameters can be set on a per-file basis from within the ~/.*rc
> > > files for most common editors just as easily.  (vim may even have
> > > a way to be configured to auto-remember those per-file parameters
> > > to ~/.viminfo)
> > > 
> > > if someone wants to create/maintain such an editor rc file that
> > > defines the desired editor parameters for each source file, that
> > > seems more favorable to me over the idea of littering magic
> > > comments throughout the files in the source tree.  the rc file
> > > may then be included into anyones editor rc files who desires
> > > it.  also I would imagine that different magic comments would
> > > need to be added to every file for every editor that comes along,
> > > which would mean patching every source file individually.
> > > *shiver*  With an rc file, for any new editor just another single
> > > rc file would need to be created.
> > 
> > That sound interesting, I'll look at it. But I suppose the
> > "anti-tags" would have the same objections, as it is in effect the
> > same, just at a different place.
> 
> Not at all.  Tags would clutter up each individual source file.
> Resource files would not even need to be part of the MPlayer
> repository.

But your wording seems to imply you don't want them in the repo, or?
Sure I can do whatever I want in my $HOME, but if they can't be
published with the rest of the MPlayer code, that severely reduce their
usefulness.

	Albeu




More information about the MPlayer-dev-eng mailing list