[MPlayer-dev-eng] [RFC] split cfg-common.h

Alban Bedel albeu at free.fr
Wed Apr 9 18:39:32 CEST 2008


On Wed, 9 Apr 2008 17:24:14 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> On Wed, Mar 05, 2008 at 01:01:35AM +0100, Diego Biurrun wrote:
> > Currently cfg-common.h is split into two parts by the MAIN_CONF
> > preprocessor condition.  This allows cfg-mplayer.h and
> > cfg-mencoder.h, to #include it twice, once with MAIN_CONF #defined
> > and once without.
> > 
> > The very same effect can be achieved by simply splitting
> > cfg-common.h into two parts.  IMO this deobfuscates cfg-common.h
> > quite a bit.  Here is a patch to achieve this.
> > 
> > cfg-common_main.h is a terribly good filename.  I'd be glad to hear
> > better suggestions.
> 
> cfg-common_opts.h should be much better.  I will commit this on Friday
> unless I hear objections.

If we are nitpicking, I would suggest using only dash or underscore,
mixing both is ugly imho.

	Albeu




More information about the MPlayer-dev-eng mailing list