[MPlayer-dev-eng] [PATCH] Runtime colorful and/or module name output control

[Diego Biurrun]

On Wed, Apr 09, 2008 at 04:25:07PM +0800, Zuxy Meng wrote:
> 
> 2008/4/9, Diego Biurrun <diego at biurrun.de>:
> > On Mon, Apr 07, 2008 at 04:20:11PM +0800, Zuxy Meng wrote:
> > >
> > > --- configure ?????? 26340??
> > > +++ configure ????????????
> > > @@ -7544,14 +7540,6 @@
> > >
> > > -echocheck "color console output"
> > > -if test "$_color_console" = yes ; then
> > > -  _def_color_console='#define MSG_USE_COLORS 1'
> > > -else
> > > -  _def_color_console='#undef MSG_USE_COLORS'
> >
> > You are removing the definition.  Remove all uses as well!
> 
> OK. Removed one that is already commented out...
> 
> See attached.

> --- mp_msg.c	?????? 26348??
> +++ mp_msg.c	????????????
> @@ -86,9 +85,92 @@
>  
> +        if(flag)

nit: inconsistent use of 'if(' vs. 'if ('.

> --- DOCS/man/en/mplayer.1	?????? 26348??
> +++ DOCS/man/en/mplayer.1	????????????
> @@ -692,6 +692,14 @@
> +.
> +.TP
> +.B \-msgmod
> +Prepend module name in front of each console message.

The option should really be called 'msgmodule'.  Apart from this I'm OK
with the patch.

Diego