[MPlayer-dev-eng] [PATCH] Fix useless dependencies in the stream lib

[Alban Bedel]

On Tue, 8 Apr 2008 20:32:03 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> On Tue, Apr 08, 2008 at 08:47:54PM +0200, Alban Bedel wrote:
> > On Tue, 8 Apr 2008 19:36:29 +0200
> > Diego Biurrun <diego at biurrun.de> wrote:
> > 
> > > Not everybody here uses emacs or vim and I cannot see how adding
> > > magic tags to all files could be less contentious than mandating a
> > > single style.
> > 
> > Sure not everybody use one of those. But any decent programming
> > editor is either compatible with vi and/or emacs tags or implement
> > his own. Also I would be ready to bet that at least half of the ppl
> > with svn account use vi, emacs or a compatible derivative.
> 
> I'll hold that bet.  What do you want to wager?  A beer at next
> LinuxTag?  A night's beers? :-)

OK :) Although, a night's beer might be a bit too much, I know quiet
well the kind of beer consumption Germans are capable of ;)

> I generally use vim for quick edits and GNU emacs for longer sessions.

Same here with jed as a middle ground (particularly for remote
sessions). For development (which is the point in case here) I
exclusively use emacs.

> > Now if you look at the current situation, one have to look at the
> > style used and manually set it (a joy when the style doesn't match
> > any of the one predefined in your editor) or fight with indentation
> > a lot. Add to that a bit of laziness and/or oversight on the devs
> > side and you get the mess we have today.
> > 
> > With the tags at least a good portion of the devs would now have to
> > fight their editor to _not_ respect the file's style. IMHO that
> > would be a large improvement, especially when you take in account
> > that tags are unobtrusive and don't need to be applied to all files
> > at once. Sure it won't solve the problem for everybody, but that
> > would still be a non negligible improvement.
> 
> I think you will have a hard time reaching such a consensus.  Getting
> people to agree on a common style should not be much harder.

We don't really need everybody to agree. If some maintainer hate tags
for some reason he is free to forbid them in the files he maintain.
For files without maintainer obviously we will need some consensus, but
I doubt that debating adding a few comments would be as inflammatory as
breaking a long established tradition.

> > The only downside I can see is that it would give lees reasons to
> > have a common style ;)
> 
> That's a good reason, why reduce the pain threshold? ;-)

IMHO if we start tagging some files, it would probably give some more
insensitive to clean files with mixed indentation. Which after all
might be a good occasion to try getting them to use your common style ;)

	Albeu