[MPlayer-dev-eng] [PATCH] Fix useless dependencies in the stream lib

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Apr 8 20:12:01 CEST 2008


On Tue, Apr 08, 2008 at 05:57:42PM +0200, Alban Bedel wrote:
> > > --- libmpdemux/asfguid.h	(revision 0)
> > > +++ libmpdemux/asfguid.h	(revision 0)
> > > @@ -0,0 +1,83 @@
> > > +#ifndef MPLAYER_ASFGUID_H
> > > +#define MPLAYER_ASFGUID_H
> > 
> > Please give new files proper license headers, see drivers/*.c for a
> > template.
> 
> Right, sorry about that. I didn't really knew who should be put as
> copyright holder. I settled for the original author of the file this
> was taken from, I hope it's ok.

If you are pedantic, for asfguid.h probably whoever wrote (most of)
find_asf_guid, nothing else seems copyrightable.
While it is little enough to still be acceptable, what I do not like
about this is that it duplicates data in the binary and probably
increases binary size by a few 100 bytes.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list