[MPlayer-dev-eng] [PATCH] Fix useless dependencies in the stream lib

[Diego Biurrun]

On Tue, Apr 08, 2008 at 05:57:42PM +0200, Alban Bedel wrote:
> On Tue, 8 Apr 2008 01:21:11 +0200
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > On Mon, Apr 07, 2008 at 02:33:55PM +0200, Alban Bedel wrote:
> > > 
> > > recently Diego asked me if I could take a look at fixing
> > > compilation of the netstream server (in fact under threat of simply
> > > rm'ing it). As part of this a few useless dependencies in the
> > > stream lib must be fixed.
> > 
> > It seems my strategy paid off ;-)
> 
> It did, I just hope we'll also see some effort on the build system side
> of the problem ;)

Sure, you should have noticed me working on the build system these past
days...

> > > --- libmpdemux/asfguid.h	(revision 0)
> > > +++ libmpdemux/asfguid.h	(revision 0)
> > > @@ -0,0 +1,83 @@
> > > +#ifndef MPLAYER_ASFGUID_H
> > > +#define MPLAYER_ASFGUID_H
> > 
> > Please give new files proper license headers, see drivers/*.c for a
> > template.
> 
> Right, sorry about that. I didn't really knew who should be put as
> copyright holder. I settled for the original author of the file this
> was taken from, I hope it's ok.

Should be OK, if the stuff you copy over was actually written by that
person.

The patch is OK from my side, though maybe you will want to wait on
Reimar or so to comment.  If you wish to earn some good karma, make the
new file match FFmpeg coding style.

Diego