[MPlayer-dev-eng] libvo changes

[Michael Niedermayer]

On Wed, Apr 02, 2008 at 07:56:04PM +0200, Reimar Döffinger wrote:
[...]
> > diff --git a/libmpcodecs/vf_vo.c b/libmpcodecs/vf_vo.c
> > index f0daa59..63306f7 100644
> > --- a/libmpcodecs/vf_vo.c
> > +++ b/libmpcodecs/vf_vo.c
> > @@ -103,13 +103,13 @@ static int control(struct vf_instance_s* vf, int request, void* data)
> >      {
> >  	vf_equalizer_t *eq=data;
> >  	if(!vo_config_count) return CONTROL_FALSE; // vo not configured?
> > -	return((video_out->control(VOCTRL_SET_EQUALIZER, eq->item, eq->value) == VO_TRUE) ? CONTROL_TRUE : CONTROL_FALSE);
> > +	return((video_out->control(VOCTRL_SET_EQUALIZER, VOCTRL_SET_EQUALIZER_ARGS(eq->item, eq->value)) == VO_TRUE) ? CONTROL_TRUE : CONTROL_FALSE);
> >      }
> 
> Personally, I find this line rather too crowded as it is, a
> struct voctrl_set_equalizer_args param = {eq->item, &eq->value};
> in a extra line would look much better IMO.

Its not easy to write clean looking code that breaks gcc 2.95, it was
hard enough to hide it behind this macro.
Well, as long as you are ok with replacing that with a mix of statements
and declarations the author will surely remove it ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080407/5a730c31/attachment.pgp>