[MPlayer-dev-eng] [PATCH] Apple Remote support double click

[Diego Biurrun]

On Fri, Sep 28, 2007 at 11:58:37PM -0400, Ergzay wrote:
> 
> On 2007/09/28, at 8:03, Ulion wrote:
> 
> > 2007/9/28, The Wanderer <inverseparadox at comcast.net>:
> >> Ulion wrote:
> >>
> >>>> the idea was to keep the patch as small as possible and w/out much
> >>>> overhead.
> >>>>
> >>>> currently there are some cosmetics like
> >>>>
> >>>> -            // read out all pending events
> >>>> -            while (result == kIOReturnSuccess)
> >>>> -                result = (*queue)->getNextEvent(queue, &event,
> >>>> zeroTime, 0);
> >>>> +            // Read out all pending events.
> >>>> +            while (ret != MP_INPUT_NOTHING)
> >>>> +                ret = mp_input_ar_read_raw(&eventTime);
> >>>>
> >>>> That you may avoid/commit separately.
> >>>
> >>> This place you pointed out, is necessary for this patch. First line
> >>> is comment fix, that should be fixed for each patch Diego reviewed.
> >>
> >> Comment fixes (at least ones which do not change the effective meaning
> >> of the comment) are still cosmetic, and I believe there is precedent 
> >> for
> >> them being applied separately.
> >
> > Since you insist, I give a patch without this comment fix.
> 
> I am nitpicking here, but why is there this precedent in the first 
> place. I would think if something can be made better go for it. The 
> only reason not to I would think, is that in the svn commit log it 
> doesn't look "nice." Which IMHO is a pretty useless reason not to make 
> something better. I'm no developer but, from what I've seen from 
> lurking on mplayer-dev is that two of the major reasons that mplayer 
> development is so slow of late is that 1. there is resistance to change 
> from certain people and 2. patches end up getting ignored (not seen?) a 
> lot and useful features and developers go untapped. Rant complete. 

What we lack is reviewers, not people sending in patches.  So we need to
shift as much work as possible away from the reviewers.  It boils down
to this in the end.

Unfortunately most people are too lazy to review and commit patches.  If
you have the magic fix for this problem, I can assure you that we're all
ears ...

Anyway, I committed the typo fix separately.

Diego