[MPlayer-dev-eng] external FAAD is broken (was Re: About ADTS header, add adts header to raw aac data)

[Dominik 'Rathann' Mierzejewski]

On Wednesday, 26 September 2007 at 10:45, Dominik 'Rathann' Mierzejewski wrote:
> On Wednesday, 26 September 2007 at 08:26, Dominik 'Rathann' Mierzejewski wrote:
> > On Wednesday, 26 September 2007 at 03:33, Giacomo Comes wrote:
> > > On Tue, Sep 25, 2007 at 11:09:48PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > > > On Tuesday, 25 September 2007 at 23:03, Giacomo Comes wrote:
> > > > > On Tue, Sep 25, 2007 at 10:10:24PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > > > > > On Tuesday, 25 September 2007 at 10:54, Nico Sabbi wrote:
> > > > > > > Il Tuesday 25 September 2007 10:49:58 Nico Sabbi ha scritto:
> > > > > > > > if(es->extradata && es->extradata_len)
> > > > > > > > {
> > > > > > > >  sh->wf = (WAVEFORMATEX *) malloc(sizeof(WAVEFORMATEX) +
> > > > > > > > es->extradata_len);
> > > > > > > > sh->wf->cbSize = es->extradata_len;
> > > > > > > > memcpy(sh->wf + 1, es->extradata,es->extradata_len);
> > > > > > > > }
> > > > > > > 
> > > > > > > btw, there are also other things to consider:
> > > > > > > - always add --disable-faad-internal to mplayer's configure (use faad 
> > > > > > > from cvs instead)
> > > > > > > - there are few rare object types such as BSAC that faad doesn't 
> > > > > > > decode
> > > > > > 
> > > > > > FAAD 2.5 doesn't work on half of the HD trailers from www.apple.com/trailers/ .
> > > > > > Neither does FAAD CVS, for that matter. All I get is:
> > > > > > FAAD: Failed to decode frame: Bitstream value not allowed by specification
> > > > > > repeated tens of times before playback.
> > > > > > 
> > > > > > For example with this trailer
> > > > > > http://images.apple.com/movies/fox/the_simpsons_movie/the_simpsons_movie-tlr_h720p.mov
> > > > > > I have the problem as seen in the attached 0mplayer.log (silence is played instead
> > > > > > of audio). With internal FAAD (1mplayer.log), the file plays fine.
> > > > > 
> > > > > I can play fine the audio of this trailer both with internal faad
> > > > > and with faad2.5 (intel 32bit)
> > > > > 
> > > > > So, saying FAAD2.5 is broken is incorrect.
> > > > 
> > > > It is broken on my system (which is, as you can see from the logs, 64bit),
> > > > but your report makes me want to try on a 32bit machine.
> > > 
> > > Did you compile faad passing the option --with-drm to configure?
> > > If yes, remove it and probably it will fix your problem.
> > > If you are using a precompiled version of faad2.5 then may be it has been
> > > made using --with-drm. Try to compile it yourself.
> > 
> > I *am* compiling it yourself to create a package. And yes, it's configured
> 
> s/yourself/myself/
> 
> That's what I get for writing before I fully wake up.

That solved the problem! Thanks a lot.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://mplayerhq.hu http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan