[MPlayer-dev-eng] [PATCH] Crash when invalid file is supplied as a playlist

[Jernej Azarija]

I made a 3 second skim on the code to find this :

 23   play_tree_t* r = calloc(1,sizeof(play_tree_t));
 24   if(r == NULL)
 25     mp_msg(MSGT_PLAYTREE,MSGL_ERR,"Can't allocate %d bytes of
memory\n",(int)sizeof(play_tree_t));
 26   r->entry_type = PLAY_TREE_ENTRY_NODE;

If the code is full of such stuff then it's indeed time for a rewrite.
I'd only need some specifications about what the code should actually
do (i'm clueles about playlist stuff) and an ack that it's indeed a
good thing to make a rewrite/audit.

On 9/24/07, Compn <tempn at twmi.rr.com> wrote:
> On Mon, 24 Sep 2007 16:27:32 +0200, Jernej Azarija scribed:
>
>
> >It'll be reasonable to redesign the playlist code to even not bother
> >opening weird files such as directories.
> >
> >Jernej Azarija.
>
>
> i think its unmaintained and has possible security risks.
> feel free to rewrite it
>
> -compn
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
>