[MPlayer-dev-eng] [PATCH] af_scaletempo

[Uoti Urpala]

On Wed, 2007-09-12 at 17:44 -0400, Robert Juliano wrote:
> usage: mplayer -af scaletempo [-speed scale]
> 
> It's linked to playback_speed, so the audio scales to match
> speed whenever the speed changes (by -speed, keyboard, menu,
> command, or property).

Activating this filter makes audio clearly "wobbly" even when speed is
1. That's bad as you don't want the ability to use this filter when
adjusting speed to ruin the parts you play at normal speed. It would be
easy to special-case this (also reducing performance overhead at default
speed), but I wonder if this demonstrates some kind of bug or suboptimal
choice in the implementation which also affects other speeds.

> Since this filter exposes a bug in lib/af.c:af_calc_insize_constrained
> you'll also want the af_calc_insize_constrained_overflow_quickfix from:
> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2007-June/052315.html

I've also noticed some other issues in the audio decoding system which
become more visible with this filter. I intend to clean those at some
point, but it'll probably have to wait until after the release (assuming
the release happens during the starting week).